feat: hangfire crons #3046
feat: hangfire crons #3046
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- hangfire crons ([#3046](https://github.com/getsentry/sentry-dotnet/pull/3046))If none of the above apply, you can opt out of this check by adding |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3046 +/- ##
==========================================
- Coverage 75.73% 75.38% -0.35%
==========================================
Files 357 351 -6
Lines 13466 13259 -207
Branches 2671 2644 -27
==========================================
- Hits 10198 9995 -203
+ Misses 2593 2589 -4
Partials 675 675 ☔ View full report in Codecov by Sentry. |
| @@ -0,0 +1,10 @@ | |||
| # Sentry for Hangfire | |||
|
|
|||
| This is a standard ASP.NET Core app with nothing in it but Hangfire. | |||
There was a problem hiding this comment.
Does the Cron stuff take place in Sentry.Io then?
There was a problem hiding this comment.
Hangfire spins up the jobs. The integration we build just pings Sentry with check-ins. Successful or not. If Sentry fails to get check-ins it can alert u (job is dead?)
There was a problem hiding this comment.
Fresh off the oven: https://blog.sentry.io/cron-monitoring-is-now-generally-available/
There was a problem hiding this comment.
Hangfire spins up the jobs. The integration we build just pings Sentry with check-ins. Successful or not. If Sentry fails to get check-ins it can alert u (job is dead?)
That's what I figured... I guess I'm wondering what this sample is for. You couldn't use it without deploying it on a public URL somewhere and configuring a cron on Sentry right?
|
@bitsandfoxes @jamescrosswell feel free to close this PR and open a new one on the same branch, otherwise it'll be a contribution from me which I didnt' do anythig other than add a sample 😅 |
|
Superseded by #3128 |
WIP