Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Skipping package signing check during workload installation #2878

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix: Skipping package signing check during workload installation #2878

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b0b225
no-sign
bitsandfoxes Nov 21, 2023
de21533
-
bitsandfoxes Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/actions/environment/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ runs:
maui-android \
${{ runner.os == 'macOS' && 'maui-ios maui-maccatalyst maui-windows maui-tizen' || '' }} \
${{ runner.os == 'Windows' && 'maui-windows' || '' }} \
--temp-dir "${{ runner.temp }}" --from-rollback-file rollback.json
--temp-dir "${{ runner.temp }}" --from-rollback-file rollback.json \
--skip-sign-check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--skip-sign-check
--skip-sign-check
# Skipping signing check above because: https://github.com/dotnet/maui/issues/9573

Unrelated but didnt' we remove rollback.json ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did on the feat/4.0.0 branch

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this has something to do with the --from-rollback-file parameter. We weren't experiencing these problems on the feat/4.0.0 branch where that parameter had been removed.


# We build Sentry.Maui for every supported MAUI target so we can access platform-specific features.
# That includes Tizen. We don't need the entire Tizen SDK, but we do need the base Tizen workload.
Expand Down