fix: Skipping package signing check during workload installation #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
changed the title
| @@ -42,7 +42,8 @@ runs: | |||
| maui-android \ | |||
| ${{ runner.os == 'macOS' && 'maui-ios maui-maccatalyst maui-windows maui-tizen' || '' }} \ | |||
| ${{ runner.os == 'Windows' && 'maui-windows' || '' }} \ | |||
| --temp-dir "${{ runner.temp }}" --from-rollback-file rollback.json | |||
| --temp-dir "${{ runner.temp }}" --from-rollback-file rollback.json \ | |||
| --skip-sign-check | |||
There was a problem hiding this comment.
Suggested change
| --skip-sign-check | |
| --skip-sign-check | |
| # Skipping signing check above because: https://github.com/dotnet/maui/issues/9573 |
Unrelated but didnt' we remove rollback.json ?
There was a problem hiding this comment.
We did on the feat/4.0.0 branch
There was a problem hiding this comment.
I wonder if this has something to do with the --from-rollback-file parameter. We weren't experiencing these problems on the feat/4.0.0 branch where that parameter had been removed.
jamescrosswell
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, this is the way to go: dotnet/maui#9573 (comment)
#skip-changelog