Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log only if transaction exists #2862

Merged
merged 2 commits into from
Nov 19, 2023
Merged

fix: log only if transaction exists #2862

merged 2 commits into from
Nov 19, 2023

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Nov 18, 2023 •
edited
Loading

I see this on the log output:

  Debug: Ending transaction as Aborted, due to unhandled exception.

When no transaction is going on. Got me quite confused at first

#skip-changelog

@bruno-garcia bruno-garcia enabled auto-merge (squash) November 18, 2023 23:59
vaind
vaind approved these changes Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find

@bruno-garcia bruno-garcia merged commit 4d239a5 into main Nov 19, 2023
14 checks passed
@bruno-garcia bruno-garcia deleted the fix/debug-logging-misleading branch November 19, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaind vaind vaind approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes bitsandfoxes is a code owner

@jamescrosswell jamescrosswell Awaiting requested review from jamescrosswell jamescrosswell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bruno-garcia @vaind