Fixed NoWarn tags for NU1903

getsentry · Sep 17, 2024 · df9bb0e · df9bb0e
1 parent eaca732
commit df9bb0e
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 27 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -16,6 +16,9 @@
     <!-- Allow references to unsigned assemblies (like MAUI) from signed projects -->
     <NoWarn>$(NoWarn);CS8002</NoWarn>
 
+    <!-- We need to support old stuff. Applications should definitely address these advisory warnings though. -->
+    <NoWarn>$(NoWarn);NU1903</NoWarn>
+
     <!-- https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/dotnet-restore-audit#version-introduced -->
     <WarningsNotAsErrors>NU1903</WarningsNotAsErrors>
   </PropertyGroup>

diff --git a/src/Sentry.AspNetCore.Blazor.WebAssembly/Sentry.AspNetCore.Blazor.WebAssembly.csproj b/src/Sentry.AspNetCore.Blazor.WebAssembly/Sentry.AspNetCore.Blazor.WebAssembly.csproj
@@ -4,8 +4,6 @@
     <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
     <VersionSuffix>preview.1</VersionSuffix>
     <RootNamespace>Sentry.AspNetCore.Blazor.WebAssembly</RootNamespace>
-    <!-- https://github.com/advisories/GHSA-hh2w-p6rv-4g7w -->
-    <NoWarn>NU1903</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/Sentry.Hangfire/Sentry.Hangfire.csproj b/src/Sentry.Hangfire/Sentry.Hangfire.csproj
@@ -16,22 +16,6 @@
     <PackageReference Include="Hangfire.Core" Version="1.8.12" />
   </ItemGroup>
 
-  <ItemGroup Condition="'$(TargetFramework)' == 'net462'">
-    <PackageReference Include="Newtonsoft.Json" Version="[5.0.1,)">
-      <!-- We can't add NU1903 to the project as this causes a CS8002 Referenced assembly does not have a strong name. -->
-      <!-- https://github.com/advisories/GHSA-5crp-9r3c-p9vr -->
-      <NoWarn>NU1903</NoWarn>
-    </PackageReference>
-  </ItemGroup>
-
-  <ItemGroup Condition="'$(TargetFramework)' != 'net462'">
-    <PackageReference Include="Newtonsoft.Json" Version="[11.0.1,)">
-      <!-- We can't add NU1903 to the project as this causes a CS8002 Referenced assembly does not have a strong name. -->
-      <!-- https://github.com/advisories/GHSA-5crp-9r3c-p9vr -->
-      <NoWarn>NU1903</NoWarn>
-    </PackageReference>
-  </ItemGroup>
-
   <ItemGroup>
     <InternalsVisibleTo Include="Sentry.Hangfire.Tests" PublicKey="$(SentryPublicKey)" />
   </ItemGroup>

diff --git a/src/Sentry.Profiling/Sentry.Profiling.csproj b/src/Sentry.Profiling/Sentry.Profiling.csproj
@@ -5,8 +5,6 @@
     <TargetFrameworks>net8.0;net6.0</TargetFrameworks>
     <PackageTags>$(PackageTags);Profiling;Diagnostic</PackageTags>
     <Description>Performance profiling support for Sentry - Open-source error tracking that helps developers monitor and fix crashes in real time.</Description>
-    <!-- https://github.com/advisories/GHSA-7jgj-8wvc-jh57 -->
-    <NoWarn>NU1903</NoWarn>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(FrameworkSupportsAot)' == 'true'">

diff --git a/src/Sentry/Sentry.csproj b/src/Sentry/Sentry.csproj
@@ -82,13 +82,7 @@
 
   <!-- Ensure at least version 6 of System.Text.Json so we have JsonSerializationContext available -->
   <ItemGroup Condition="$(TargetFramework.StartsWith('net4')) or $(TargetFramework.StartsWith('netstandard'))">
-    <PackageReference Include="System.Text.Json" Version="6.0.8" >
-    <!--
-      Ignoring the vulnerability warning: https://github.com/advisories/GHSA-hh2w-p6rv-4g7w
-      The app can/should pin to the latest version. We will bump once a patch on v6 is out (still LTS until Nov 24).
-    -->
-      <NoWarn>NU1903</NoWarn>
-    </PackageReference>
+    <PackageReference Include="System.Text.Json" Version="6.0.9" />
   </ItemGroup>
 
   <!--