-
-
Notifications
You must be signed in to change notification settings - Fork 35
feat(multi-module): Introduce SentryRootPlugin with App and Lib subplugins #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -2,7 +2,7 @@ root = true | |||
|
|||
[*] | |||
indent_style = space | |||
indent_size = 4 | |||
indent_size = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a leftover from ktlint -> ktfmt migration
|
@@ -28,7 +31,7 @@ include(":examples:android-gradle") | |||
|
|||
include(":examples:android-gradle-kts") | |||
|
|||
include(":examples:android-guardsquare-proguard") | |||
// include(":examples:android-guardsquare-proguard") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason this sample doesn't work but I will figure it out later (or maybe drop the sample altogether, as it's problematic to support it given there's no plans to support AGP 8+ from the proguard side)
#skip-changelog
📜 Description
io.sentry.gradle
plugin that has to be applied on the root project level. The plugin then:subprojects
and applies the respective subplugins depending on what plugins are currently applied to the gradle projectio.sentry.android.gradle
plugin is in place and throws as they are incompatible and can't be used togetherio.sentry.android.gradle
and print a message to switch over to the new root plugin💡 Motivation and Context
Closes #800
💚 How did you test it?
So far just manually, will add/convert existing tests later
📝 Checklist
🔮 Next steps