Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get_app_version): work as intended, add tests #846

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

malept
Copy link
Member

@malept malept commented Dec 20, 2024

What this PR does / why we need it

Porting over the Magefile version of get_app_version did not work as intended, and it's unclear why.

  • Removed --always from git describe so that a repo without any tags actually uses the fallback.
  • Updated the value passed to --match to be a glob instead of a regex, per the docs.
  • Minor change: prefix fallback version with v for consistency

Also adds tests to show what it's supposed to do.

Jira ID

DT-4561

Notes for your reviewers

--always documentation from git describe --help:

       --always
           Show uniquely abbreviated commit object as fallback.

@malept malept requested a review from a team as a code owner December 20, 2024 18:43
Copy link
Contributor

@richardlarocque richardlarocque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@getoutreach-ci-2
Copy link

Link to code coverage report (posted by coverbot 🤖)

Copy link

@ekalinichev ekalinichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are unit tests for Bash? Nice )

@malept malept merged commit b0e264d into main Dec 30, 2024
4 checks passed
@malept malept deleted the malept/dt-4561/fix/get_app_version-fixes branch December 30, 2024 18:25
@getoutreach-ci-1
Copy link
Contributor

🎉 This PR is included in version 2.29.0-rc.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants