fix(get_app_version): work as intended, add tests #846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Porting over the Magefile version of
get_app_version
did not work as intended, and it's unclear why.--always
fromgit describe
so that a repo without any tags actually uses the fallback.--match
to be a glob instead of a regex, per the docs.v
for consistencyAlso adds tests to show what it's supposed to do.
Jira ID
DT-4561
Notes for your reviewers
--always
documentation fromgit describe --help
: