fix: missing optional check in serializers

getmeli · Mar 19, 2021 · ca36dcb · ca36dcb
1 parent 7c261f1
commit ca36dcb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/hooks/handlers/web/get-payload.ts b/src/hooks/handlers/web/get-payload.ts
@@ -12,6 +12,7 @@ import { Branch } from '../../../entities/sites/branch';
 import { Release } from '../../../entities/releases/release';
 import { getBranchUrl } from '../../../entities/sites/get-branch-url';
 import { getSiteUrl } from '../../../entities/sites/get-site-url';
+import { serializeForm } from '../../../entities/forms/serialize-form';
 
 function serializeUser(user: User) {
   return {
@@ -96,7 +97,7 @@ function serializeBranch(site: Site, branch: Branch) {
     slug: branch.slug,
     release: branch.release,
     hasPassword: !!branch.password,
-    redirects: branch.redirects.map(redirect => ({
+    redirects: branch.redirects?.map(redirect => ({
       _id: redirect._id,
       type: redirect.type,
       path: redirect.path,
@@ -140,6 +141,7 @@ function serializeRelease(release: Release) {
     name: release.name,
     date: release.date,
     branches: release.branches,
+    forms: release.forms?.map(serializeForm),
   };
 }
 

diff --git a/src/socket/message-builders.ts b/src/socket/message-builders.ts
@@ -6,6 +6,7 @@ import { getBranchUrl } from '../entities/sites/get-branch-url';
 import { Branch } from '../entities/sites/branch';
 import { Team } from '../entities/teams/team';
 import { Release } from '../entities/releases/release';
+import { serializeForm } from '../entities/forms/serialize-form';
 
 function serializeTeam(team: Team) {
   return {
@@ -25,7 +26,7 @@ function serializeBranch(site: Site, branch: Branch) {
     slug: branch.slug,
     release: branch.release,
     hasPassword: !!branch.password,
-    redirects: branch.redirects.map(redirect => ({
+    redirects: branch.redirects?.map(redirect => ({
       _id: redirect._id,
       type: redirect.type,
       path: redirect.path,
@@ -61,6 +62,7 @@ function serializeRelease(release: Release) {
     name: release.name,
     date: release.date,
     branches: release.branches,
+    forms: release.forms?.map(serializeForm),
   };
 }