feat(dunning): Add permission to DunningCampaignsResolver

app/config/permissions/definition.yml

@@ -31,6 +31,7 @@ customers:
   update:
   delete:
 dunning_campaigns:
+  view:
   create:
 subscriptions:
   view: true

app/config/permissions/role-finance.yml

@@ -27,6 +27,7 @@ customers:
   update: false
   delete: false
 dunning_campaigns:
+  view: true
   create: true
 subscriptions:
   create: false

app/config/permissions/role-manager.yml

@@ -27,6 +27,7 @@ customers:
   update: true
   delete: true
 dunning_campaigns:
+  view: false
   create: false
 subscriptions:
   create: true

app/graphql/resolvers/dunning_campaigns_resolver.rb

@@ -7,6 +7,8 @@ class DunningCampaignsResolver < Resolvers::BaseResolver
 
     description "Query dunning campaigns of an organization"
 
+    REQUIRED_PERMISSION = "dunning_campaigns:view"
+
     argument :applied_to_organization, Boolean, required: false
     argument :limit, Integer, required: false
     argument :order, String, required: false

spec/graphql/resolvers/dunning_campaigns_resolver_spec.rb

@@ -3,6 +3,7 @@
 require "rails_helper"
 
 RSpec.describe Resolvers::DunningCampaignsResolver, type: :graphql do
+  let(:required_permission) { "dunning_campaigns:view" }
   let(:query) do
     <<~GQL
       query {
@@ -20,10 +21,15 @@
 
   before { dunning_campaign }
 
-  it "returns a list of dunning campaigns" do
+  it_behaves_like "requires current user"
+  it_behaves_like "requires current organization"
+  it_behaves_like "requires permission", "dunning_campaigns:view"
+
+  it "returns a list of dunning campaigns", :aggregate_failures do
     result = execute_graphql(
       current_user: membership.user,
       current_organization: organization,
+      permissions: required_permission,
       query:
     )
 
@@ -55,6 +61,7 @@
       result = execute_graphql(
         current_user: membership.user,
         current_organization: create(:organization),
+        permissions: required_permission,
         query:
       )
 

spec/queries/dunning_campaigns_query_spec.rb

@@ -17,7 +17,7 @@
     create(:dunning_campaign, organization:, name: "defgh", code: "11", applied_to_organization: true)
   end
   let(:dunning_campaign_second) do
-    create(:dunning_campaign, organization:, name: "abcde", code: "22", applied_to_organization: true)
+    create(:dunning_campaign, organization:, name: "abcde", code: "22", applied_to_organization: false)
   end
 
   let(:dunning_campaign_third) do
@@ -45,7 +45,7 @@
   context "with pagination" do
     let(:pagination) { {page: 2, limit: 2} }
 
-    it "applies the pagination" do
+    it "applies the pagination", :aggregate_failures do
       aggregate_failures do
         expect(result).to be_success
         expect(result.dunning_campaigns.count).to eq(1)
@@ -70,7 +70,7 @@
     let(:filters) { {applied_to_organization: false} }
 
     it "returns only one dunning campaign" do
-      expect(result.dunning_campaigns).to eq([dunning_campaign_third])
+      expect(result.dunning_campaigns).to eq([dunning_campaign_second, dunning_campaign_third])
     end
   end