Fix tests, still uniqueness validation failing...

getlago · Feb 20, 2025 · 35192ae · 35192ae
1 parent 16121be
commit 35192ae
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/app/models/billing_entity/applied_tax.rb b/app/models/billing_entity/applied_tax.rb
@@ -6,6 +6,8 @@ class AppliedTax < ApplicationRecord
 
     belongs_to :billing_entity
     belongs_to :tax
+
+    validates :tax_id, uniqueness: {scope: :billing_entity_id}
   end
 end
 

diff --git a/spec/models/billing_entity/applied_tax_spec.rb b/spec/models/billing_entity/applied_tax_spec.rb
@@ -8,8 +8,5 @@
   it { is_expected.to belong_to(:billing_entity) }
   it { is_expected.to belong_to(:tax) }
 
-  it { is_expected.to validate_presence_of(:billing_entity) }
-  it { is_expected.to validate_presence_of(:tax) }
-
   it { is_expected.to validate_uniqueness_of(:tax_id).scoped_to(:billing_entity_id) }
 end
-Original file line number
+Diff line change
@@ Expand Up / @@ -6,6 +6,8 @@ class AppliedTax < ApplicationRecord @@
         belongs_to :billing_entity
         belongs_to :tax
+        validates :tax_id, uniqueness: {scope: :billing_entity_id}
       end
     end
@@ Expand Down @@