feat(dunning): Add permission to DunningCampaignsResolver

getlago · Oct 15, 2024 · 1a13eb6 · 1a13eb6
1 parent 236f39b
commit 1a13eb6
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 0 deletions.
diff --git a/app/config/permissions/definition.yml b/app/config/permissions/definition.yml
@@ -31,6 +31,7 @@ customers:
   update:
   delete:
 dunning_campaigns:
+  view:
   create:
 subscriptions:
   view: true

diff --git a/app/config/permissions/role-finance.yml b/app/config/permissions/role-finance.yml
@@ -27,6 +27,7 @@ customers:
   update: false
   delete: false
 dunning_campaigns:
+  view: true
   create: true
 subscriptions:
   create: false

diff --git a/app/config/permissions/role-manager.yml b/app/config/permissions/role-manager.yml
@@ -27,6 +27,7 @@ customers:
   update: true
   delete: true
 dunning_campaigns:
+  view: false
   create: false
 subscriptions:
   create: true

diff --git a/app/graphql/resolvers/dunning_campaigns_resolver.rb b/app/graphql/resolvers/dunning_campaigns_resolver.rb
@@ -7,6 +7,8 @@ class DunningCampaignsResolver < Resolvers::BaseResolver
 
     description "Query dunning campaigns of an organization"
 
+    REQUIRED_PERMISSION = "dunning_campaigns:view"
+
     argument :applied_to_organization, Boolean, required: false
     argument :limit, Integer, required: false
     argument :order, String, required: false

diff --git a/schema.graphql b/schema.graphql
diff --git a/schema.json b/schema.json
diff --git a/spec/graphql/resolvers/dunning_campaigns_resolver_spec.rb b/spec/graphql/resolvers/dunning_campaigns_resolver_spec.rb
@@ -3,6 +3,7 @@
 require "rails_helper"
 
 RSpec.describe Resolvers::DunningCampaignsResolver, type: :graphql do
+  let(:required_permission) { "dunning_campaigns:view" }
   let(:query) do
     <<~GQL
       query {
@@ -20,10 +21,15 @@
 
   before { dunning_campaign }
 
+  it_behaves_like "requires current user"
+  it_behaves_like "requires current organization"
+  it_behaves_like "requires permission", "dunning_campaigns:view"
+
   it "returns a list of dunning campaigns" do
     result = execute_graphql(
       current_user: membership.user,
       current_organization: organization,
+      permissions: required_permission,
       query:
     )
 
@@ -55,6 +61,7 @@
       result = execute_graphql(
         current_user: membership.user,
         current_organization: create(:organization),
+        permissions: required_permission,
         query:
       )
-Original file line number
+Diff line change
@@ Expand Up / @@ -31,6 +31,7 @@ customers: @@
       update:
       delete:
     dunning_campaigns:
+      view:
       create:
     subscriptions:
       view: true
@@ Expand Down @@