New ::submit method for fields
#7130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
| */ | ||
| public function submit(mixed $value): static | ||
| { | ||
| return $this->fill($value); |
There was a problem hiding this comment.
Understanding: E.g. with the picker fields, this would be the place where we could transform the big data array to simple list of (UU)IDs?
There was a problem hiding this comment.
Yes, exactly. We basically have two ways now:
::fill:
values come from storage, will be used for field components and might need to be transformed
::submit
values come from form submissions and will eventually go into storage and they might need to be transformed.
distantnative
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Enhancements
::submitfor fields to be used when a form is submitted in a request.::fill()is now only responsible for providing the values that the form should have on render.Breaking changes
None
Docs
Full docs for all Form changes: https://www.notion.so/getkirby/Fields-docs-1c359ef0a5cb805189b5ffdc7fa54e0b
Ready?
For review team