Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entries field overlook issues #6979

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Conversation

afbora
Copy link
Member

@afbora afbora commented Feb 7, 2025

  • Fixed discarding issue via storing field value correctly
  • Run toFormValue/toStoredValue methods for each value

@afbora afbora added this to the 5.0.0-beta.3 milestone Feb 7, 2025
@afbora afbora self-assigned this Feb 7, 2025
src/Form/Field/EntriesField.php Outdated Show resolved Hide resolved
src/Form/Field/EntriesField.php Outdated Show resolved Hide resolved
@distantnative distantnative force-pushed the fix/entries-field-issues branch from c02e199 to cc53c33 Compare February 7, 2025 19:08
@distantnative
Copy link
Member

Great fix to make it functioning properly.

I would still love to move the UUID injection to the backend, but that's its own project and not necessary to have the field function - it does with this PR.

@distantnative distantnative merged commit 26fe873 into v5/develop Feb 7, 2025
12 checks passed
@distantnative distantnative deleted the fix/entries-field-issues branch February 7, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants