-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New option to disable the vue template compiler #6965
Conversation
I've had a closer look at the coverage and I really think it's another issue from Codecov. The lines are all covered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About coverage: Probably rather than a Codecov issue, this is another PHPUnit issue where the method name cannot be marked as covered. We had that a lot, so I wouldn't be surprised if the name js
is also affected. Nothing to worry about IMO.
It seems almost as if short methods are the problem (js, vue, url...). And if we say Codecov we mean PHPunit... just the coverage part of our CI overall getting it wrong. |
Short names could indeed be a connection! |
da766cb
to
c240bcc
Compare
@distantnative the themes are great! |
Summary of changes
Todos
Assets::vue
Changelog
Enhancements