New security command
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbora
added
the
type: feature 🎉
afbora
force-pushed
the
feature/security
branch
from
bb0f4bf to
005ce24
Compare
lukasbestle
reviewed
May 25, 2024
There was a problem hiding this comment.
Sorry for the huge delay, missed the PR in the list.
I like the idea and implementation. Of course the check cannot cover everything, but mirroring the behavior of the system view for use on the CLI is a great start! We already do those checks in the system view, so offering them here as well makes a lot of sense.
|
Thanks for checking @lukasbestle. I'm fine with it after your comments. We could basically just turn this new command into a new 1.6.0 release unless we have anything else to add. |
lukasbestle
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.