Call generator function for each loop #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the initial idea of generators is not to have all in memory as this might exceed the available memory with big indexes. Which I guess this PR would force all into memory again. But I also don't have a good understanding yet why that bug is happening. |
|
Understand the idea. I'll take a look again. |
afbora
force-pushed
the
fix/72-clean-content
branch
from
c0a788f to
4eec997
Compare
afbora
changed the title
|
I've pushed correct fix. We should call kirby models (generator function) for each loop since generators cannot be cloned. Otherwise run into an exception: |
bastianallgeier
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes