Skip to content
This repository was archived by the owner on Dec 31, 2022. It is now read-only.

support TS-style comment annotations #3

Open
getify opened this issue Jul 11, 2015 · 2 comments
Open

support TS-style comment annotations #3

getify opened this issue Jul 11, 2015 · 2 comments
Assignees

Comments

@getify
Copy link
Owner

getify commented Jul 11, 2015

Per: http://stackoverflow.com/questions/12930049/how-do-i-import-other-typescript-files

+@vivainio

@getify getify self-assigned this Jul 11, 2015
@getify
Copy link
Owner Author

getify commented Jul 11, 2015

One potential issue, which may require this to be behind a flag instead of automatic: typescript may have a different interpretation of relative URLs than scantree uses. For example, TypeScript (and IDEs) may assume that a "../foo/bar.js" path is relative to the file it's included in, rather than relative to some base path setting (as scantree does).

If so, I could change the assumptions about relativity for typescript pathing, but I don't know if I could practically do so on a per-path basis (strings are all that's passed around internally). It might be a flag you have to pass (--file-relative) which changes the definition of "relative" to "relative to current file" instead of "relative to base-path".

getify added a commit that referenced this issue Jul 11, 2015

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…. also fixed some tests, updated readme docs
@getify
Copy link
Owner Author

getify commented Jul 11, 2015

So, basic support for this should now be in there as of 0.3.0-a. But need to work out if the --file-relative option is necessary to fully support how people use typescript annotations with relative paths. Will leave this open for now as we investigate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant