Fixed attribution page to use external links

getcanoe · Jun 6, 2018 · 4871693 · 4871693
1 parent 256644d
commit 4871693
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/src/js/controllers/preferencesAttributions.js b/src/js/controllers/preferencesAttributions.js
@@ -0,0 +1,8 @@
+'use strict'
+
+angular.module('canoeApp.controllers').controller('preferencesAttributions',
+  function ($scope, externalLinkService) {
+    $scope.openExternalDirect = function (url, target) {
+      externalLinkService.open(url, target)
+    }
+  })
diff --git a/src/js/routes.js b/src/js/routes.js
@@ -441,6 +441,7 @@ angular.module('canoeApp').config(function (historicLogProvider, $provide, $logP
       url: '/attributions',
       views: {
         'tab-settings@tabs': {
+          controller: 'preferencesAttributions',
           templateUrl: 'views/attributions.html'
         }
       }

diff --git a/www/views/attributions.html b/www/views/attributions.html
@@ -8,13 +8,13 @@
   <ion-content>
     <div class="list">
       <div class="item item-text-wrap" id="settings-tos">
-        <p>The sounds used in Canoe come from <a href="https://notificationsounds.com">Notification Sounds</a> and are licensed under <a href="http://creativecommons.org/licenses/by/4.0/legalcode">CC BY 4.0</a>:</p>
+        <p>The sounds used in Canoe come from <a ng-click="openExternalDirect('https://notificationsounds.com')">Notification Sounds</a> and are licensed under <a ng-click="openExternalDirect('http://creativecommons.org/licenses/by/4.0/legalcode')">CC BY 4.0</a>:</p>
         <p>
           <ul>
-            <li><a href="https://notificationsounds.com/notification-sounds/definite-555">Definite</a> - upon receive.</li>
-            <li><a href="https://notificationsounds.com/notification-sounds/definite-555">Locked</a> - upon send.</li>
-            <li><a href="https://notificationsounds.com/notification-sounds/definite-555">Confirmed</a> - upon unlock.</li>
-            <li><a href="https://notificationsounds.com/message-tones/filling-your-inbox-251">Filling your inbox</a> - upon representative changed.</li>
+            <li><a ng-click="openExternalDirect('https://notificationsounds.com/notification-sounds/definite-555')">Definite</a> - upon receive.</li>
+            <li><a ng-click="openExternalDirect('https://notificationsounds.com/notification-sounds/definite-555')">Locked</a> - upon send.</li>
+            <li><a ng-click="openExternalDirect('https://notificationsounds.com/notification-sounds/definite-555')">Confirmed</a> - upon unlock.</li>
+            <li><a ng-click="openExternalDirect('https://notificationsounds.com/message-tones/filling-your-inbox-251')">Filling your inbox</a> - upon representative changed.</li>
           </ul>
         </p>
       </div>