-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: pass all options to geocoder using $attrs #16
Conversation
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
@dd you may need to update the commit messages by following the commitlint convention mentioned here so that the required checks pass. You can rebase interactively (check the commitlint bots msg) and rename your commits: - fix query method
+ fix: query method
- update passed props to MapboxGeocoder
+ refactor: update passed props to geocoder once that's done, code LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rebase interactively so that the checks pass.
It is needed for the `npm i git+https://github.com/dd/vue-mapbox-geocoder.git` command to build the package
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
soal#16 (comment)