Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pass all options to geocoder using $attrs #16

Closed
wants to merge 4 commits into from

Conversation

dd
Copy link

@dd dd commented May 20, 2020

@ghost
Copy link

ghost commented May 20, 2020

There were the following issues with this Pull Request

  • Commit: cf924d6
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: e95f88a
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented May 20, 2020

There were the following issues with this Pull Request

  • Commit: cf924d6
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: e95f88a
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ajinkya ajinkya requested a review from vinayakkulkarni May 20, 2020 09:14
@vinayakkulkarni vinayakkulkarni changed the title Pass all options to MapboxGeocoder and fix query method refactor: pass all options to geocoder using $attrs May 20, 2020
@vinayakkulkarni
Copy link

@dd you may need to update the commit messages by following the commitlint convention mentioned here so that the required checks pass.

You can rebase interactively (check the commitlint bots msg) and rename your commits:

- fix query method
+ fix: query method

- update passed props to MapboxGeocoder
+ refactor: update passed props to geocoder

once that's done, code LGTM

Copy link

@vinayakkulkarni vinayakkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase interactively so that the checks pass.

It is needed for the `npm i git+https://github.com/dd/vue-mapbox-geocoder.git` command to build the package
@ghost
Copy link

ghost commented Jun 22, 2020

There were the following issues with this Pull Request

  • Commit: cf924d6
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: e95f88a
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 3cdfda7
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants