Feature/reduce unnecessary file read in geoschem #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
This update allows the data directory path passed to Cloud-J to not have a trailing slash. Previously this was required for Cloud-J to work. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR skips reading several Cloud-J lookup tables if using GEOS-Chem. These tables are used for Cloud-J standalone but not GEOS-Chem. The update also removes the requirement that the tables data directory passed to Cloud-J have a slash at the end of the path.
Expected changes
This is a zero diff update for Cloud-J standalone and Cloud-J within GEOS-Chem.
Reference(s)
None
Related Github Issues and PRs
None