Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for OpenSearch backend #111

Merged
merged 1 commit into from
Dec 30, 2024
Merged

add support for OpenSearch backend #111

merged 1 commit into from
Dec 30, 2024

Conversation

tomkralidis
Copy link
Member

Adds support for OpenSearch. Note that OpenSearch evaluation almost identical to Elasticsearch evaluation (the main difference being the use of opensearch-dsl vs elasticsearch-dsl. Codepaths are intentionally separate to account for additional future divergences, although I guess we can introduce a dialect of some sort to trick the ES evaluator to use OpenSearch DSL instead of Elasticsearch DSL proper.

Copy link
Contributor

@constantinius constantinius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Currently this is basically a copy of the elasticsearch, I believe.

@tomkralidis
Copy link
Member Author

lgtm Currently this is basically a copy of the elasticsearch, I believe.

Exactly, with the difference in dependencies.

@tomkralidis tomkralidis merged commit bde7dda into main Dec 30, 2024
6 checks passed
@tomkralidis tomkralidis deleted the backend-opensearch branch December 30, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants