Add support for big number in the card and chart components #85

OrlandoP97 · 2024-05-02T20:09:48Z

Use gxBigNumber for charts and card data manipulation

ncamera

Thanks for the improvements! In addition to the requested changes, did you test this change in GeneXus using the Angular Generator with some queries? It would be good to check the new behavior in a e2e case.

ncamera · 2024-05-02T20:23:24Z

package.json

@@ -67,6 +67,7 @@
  "dependencies": {
    "@genexus/reporting-api": "~3.1.0",
    "@genexus/web-controls-library": "2.3.0",
+    "@genexus/web-standard-functions": "file:///C:/PROJECTS/genexus/web-standard-functions/dist/lib-esm",


This should be a peer dependency to not force the version in this repo. Also, this should point to @genexus/web-standard-functions

Great! I did this because I understood that could be necesary to modify some web-standard-function code before start working, but actually it wasn't so I will remove that. Thanks!

ncamera · 2024-05-02T20:24:25Z

src/components/query-viewer-card/controller/card-utils.ts

@@ -302,13 +306,15 @@ const showDataAsMapping: {
 // @todo Complete the implementation of this function by comparing it to the Web implementation
 export function valueOrPercentage(


[valueOrPercentage] It would be nice to add some tests using this utility with different values to validates the new behavior.

ncamera · 2024-05-02T20:26:08Z

src/components/query-viewer-chart/controller/highcharts-options.ts

@@ -1524,7 +1524,7 @@ function groupPoints(
    dateStr: null,
    name: null
  };
-  let pointAdd: { x: string; y: number; name: string };
+  let pointAdd: { x: string; y: GxBigNumber; name: string };


[groupPoints] It would be nice to add some tests using this utility with different values to validates the new behavior.

ncamera · 2024-05-02T20:26:43Z

src/components/query-viewer-chart/controller/processDataAndMetadata.ts

@@ -512,7 +513,7 @@ function aggregatePoints(chartSerie: QueryViewerChartSerie) {
  });
  const value = aggregate(
    chartSerie.Aggregation,
-    currentYValues,
+    currentYValues.map(val => new GxBigNumber(val)),


[aggregatePoints] It would be nice to add some tests using this utility with different values to validates the new behavior.

ncamera · 2024-05-02T20:27:22Z

src/utils/general.ts

@@ -122,76 +125,94 @@ function evaluate(

 const aggregateMap: {


[aggregateMap] It would be nice to add some tests using this utility with different values to validates the new behavior.

ncamera · 2024-05-02T20:28:31Z

src/utils/general.ts

+) => {
+  return aggregateMap[aggregation || QueryViewerAggregationType.Sum](
    values,
    quantities
  );
+};


Suggested change

) => {

return aggregateMap[aggregation || QueryViewerAggregationType.Sum](

values,

quantities

);

};

) =>

aggregateMap[aggregation || QueryViewerAggregationType.Sum](

values,

quantities

);

ncamera · 2024-05-02T20:29:01Z

src/utils/general.ts

+  ) => {
+    return new GxBigNumber(quantities.reduce((a, b) => a + b, 0));
+  },


Suggested change

) => {

return new GxBigNumber(quantities.reduce((a, b) => a + b, 0));

},

) => new GxBigNumber(quantities.reduce((a, b) => a + b, 0));

ncamera · 2024-05-02T20:29:27Z

src/utils/general.ts

    values,
    quantities
  );
+};

 function aggregateDatum(


[aggregateDatum] It would be nice to add some tests using this utility with different values to validates the new behavior.

ncamera · 2024-05-02T20:36:14Z

src/utils/general.ts

+  ) => {
+    return new GxBigNumber(quantities.reduce((a, b) => a + b, 0));
+  },


Suggested change

) => {

return new GxBigNumber(quantities.reduce((a, b) => a + b, 0));

},

) =>

new GxBigNumber(quantities.reduce((a, b) => a + b, 0));

Hi Nico, thanks for the review!, I was actually tryng to upload a created branch, so this way to be able to collaborate in the feature, but I couldn't do it. Maybe I need some permissions?

I've sent you an invitation.

…0.61.0

…alueOrPercentage function tests

…ge tests

Labels and tooltips of the charts now show data as string wihout parsing, showing more precision

labels/tooltips

…eporting-controls-library into feature/gxBigNumber

- aggregateMap - aggregateDatum - groupPoints - aggregatePoints - valueOrPercentage

…@genexus/web-standard-functions

- Update calculate function, to handle operator precedence with custom BigNumber operations - Add Test for calculate function - Add aggregateDatum tests when isFormula and Sum - Add aggregateDatum tests when isFormula and Count

OrlandoP97 added 3 commits May 2, 2024 16:00

fix: update valueOrPercentage function to operate with GxBigNumber

b407083

make some experimental changes

9d2b48c

fix errors operating with bigNumbers

62383d1

ncamera self-requested a review May 2, 2024 20:21

ncamera requested changes May 2, 2024

View reviewed changes

ncamera added feature Feature implementation pull request risky Identifies a PR that has a level of risk to merging target: minor This PR is targeted for the next minor release refactoring Issue that involves refactoring or code-cleanup labels May 2, 2024

ncamera changed the title ~~Feature/gx big number~~ Add support for big number in the card and chart components May 2, 2024

OrlandoP97 and others added 18 commits May 3, 2024 16:33

chore: Update @genexus/web-standard-functions dependency to version ^…

c409144

…0.61.0

Merge remote-tracking branch 'upstream/main' into feature/gxBigNumber

c127fed

use commonJS for @genexus/web-standar-functions imports, card-utils v…

5e29cd9

…alueOrPercentage function tests

test: valueOrPercentage test functions with long decimal values

6b97cee

test: pass the big number with decimals as strings in valueOrPercenta…

fd57f77

…ge tests

labels/tooltips

214a9f5

Labels and tooltips of the charts now show data as string wihout parsing, showing more precision

Merge pull request #1 from ehrivero/chart

8ec9519

labels/tooltips

pass right number through label

15022ce

Merge branch 'feature/gxBigNumber' of https://github.com/OrlandoP97/r…

87758d6

…eporting-controls-library into feature/gxBigNumber

make quantityValues a gxBigNumber

4caf10c

fix error with timeline tooltip

e52a41c

add condition to fix console error

0b6a4ef

Create tests for functions affected by changes

c1c8485

- aggregateMap - aggregateDatum - groupPoints - aggregatePoints - valueOrPercentage

Merge branch 'main' into feature/gxBigNumber

3fe31b4

chore: Update npm dependencies for @genexus/web-controls-library and …

af78794

…@genexus/web-standard-functions

support bigNumbers in card when isFormula

861ce6c

Merge branch 'main' into feature/gxBigNumber

949c278

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for big number in the card and chart components #85

Add support for big number in the card and chart components #85

OrlandoP97 commented May 2, 2024

ncamera left a comment

ncamera May 2, 2024

OrlandoP97 May 2, 2024

ncamera May 2, 2024

ncamera May 2, 2024

ncamera May 2, 2024

ncamera May 2, 2024

ncamera May 2, 2024

ncamera May 2, 2024

ncamera May 2, 2024

ncamera May 2, 2024

OrlandoP97 May 2, 2024 •

edited

Loading

ncamera May 3, 2024

		@@ -302,13 +306,15 @@ const showDataAsMapping: {
		// @todo Complete the implementation of this function by comparing it to the Web implementation
		export function valueOrPercentage(

		@@ -122,76 +125,94 @@ function evaluate(

		const aggregateMap: {

Add support for big number in the card and chart components #85

Are you sure you want to change the base?

Add support for big number in the card and chart components #85

Conversation

OrlandoP97 commented May 2, 2024

ncamera left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OrlandoP97 May 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OrlandoP97 May 2, 2024 •

edited

Loading