chore: tweaks to styling pages #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentaDemnushaj
requested review from
wjhendry and
jay-taylerson
as code owners
MrBrunoWolff
reviewed
Dec 3, 2024
| @@ -148,31 +166,49 @@ import { ElementStyles, PropertyStyleSheetBehavior } from '@genesis/web-core'; | |||
| * @public | |||
| */ | |||
| export function appearanceBehavior(value: string, styles: ElementStyles) { | |||
| return new PropertyStyleSheetBehavior('appearance', value, styles); | |||
| return new PropertyStyleSheetBehavior("appearance", value, styles); | |||
There was a problem hiding this comment.
nitpick: this one should be ok to stay as it is?
| @@ -45,15 +44,19 @@ Let's override structural properties defined in the `baseStyles` by adding or mo | |||
| ##### Custom Base Styles | |||
|
|
|||
| ```typescript | |||
| import { css } from '@genesislcap/web-core'; | |||
There was a problem hiding this comment.
question: are we moving all examples to "double quotes symbol"?
There was a problem hiding this comment.
i did format document and it must have switched it
matteematt
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATTENTION! NEW DOCS STRUCTURE
FOR THE NEXT THREE WEEKS, ONLY BRANCH FROM new-docs-structure
OTHERWISE, WAIT UNTIL THE NEW STRUCTURE HAS BEEN RELEASED
Thank you for contributing to the documentation.
Do the changes you have made apply to both Current and Previous versions?
Have you done a trial build to check all new or changed links?
Is there anything else you would like us to know?
This week's exciting advice from the style guide
Write your headings in sentence case:
This is a correct heading.
This is not a correct heading.