Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new release card design #2024

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Conversation

ArturKrasinski
Copy link
Collaborator

demo:

Screen.Recording.2024-12-03.at.12.02.45.mov

@ArturKrasinski ArturKrasinski self-assigned this Dec 3, 2024
@ArturKrasinski ArturKrasinski changed the base branch from preprod to new-doc-structure December 3, 2024 11:03
@@ -0,0 +1,52 @@

.release-card {
height: 95%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this height is getting overridden so not needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for width?

Copy link
Contributor

@patrickoneill-genesis patrickoneill-genesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just that redundant bit of styles could be removed

@jay-taylerson jay-taylerson merged commit e27750a into new-doc-structure Dec 3, 2024
@jay-taylerson jay-taylerson deleted the ak/new-release-card branch December 3, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants