Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mixins utilities PTL-1696 #2016

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

Gareth-Spencer-Genesis
Copy link
Contributor

ATTENTION! NEW DOCS STRUCTURE
FOR THE NEXT THREE WEEKS, ONLY BRANCH FROM new-docs-structure
OTHERWISE, WAIT UNTIL THE NEW STRUCTURE HAS BEEN RELEASED


Thank you for contributing to the documentation.

Do the changes you have made apply to both Current and Previous versions?
No

Have you done a trial build to check all new or changed links?
Yes

Is there anything else you would like us to know?
No

This week's exciting advice from the style guide

  • Write your headings in sentence case:

    • A good example
      This is a correct heading.
    • A Bad Example
      This is not a correct heading.

template: html`<!-- template here -->`,
})
export class MyExampleComponent extends LifecycleMixin(GenesisElement) {
// Your element's implementation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we flesh this out with a simple example? Not even sure myself what we can do with this.

template: html`<!-- template here -->`,
})
export class MyExampleComponent extends PendingState(GenesisElement) {
// Element logic that involves asynchronous operations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor

@matteematt matteematt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patrick is correct we really need to flesh out the examples, but I am happy to merge this for now and then we elaborate on them later. I can take up the example for LifecycleMixin but someone else can look at the other

…_mixins-util.mdx

Co-authored-by: Matt Walker <43502076+matteematt@users.noreply.github.com>
@Gareth-Spencer-Genesis Gareth-Spencer-Genesis merged commit a08816a into new-doc-structure Dec 3, 2024
@Gareth-Spencer-Genesis Gareth-Spencer-Genesis deleted the PTL-1696 branch December 3, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants