Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: card links #2005

Merged
merged 4 commits into from
Dec 2, 2024
Merged

fix: card links #2005

merged 4 commits into from
Dec 2, 2024

Conversation

ArturKrasinski
Copy link
Collaborator

@ArturKrasinski ArturKrasinski commented Dec 2, 2024

The fixes that will ensure proper handling of BASE_URL both locally and in production.

test locally:

npm run start

and with BASE_URL

BASE_URL="/docs/" npm run start

Before the changes, adding BASE_URL causes links and images in the Card component to not work correctly.

@ArturKrasinski ArturKrasinski self-assigned this Dec 2, 2024
@ArturKrasinski ArturKrasinski changed the base branch from preprod to new-doc-structure December 2, 2024 14:57
@ArturKrasinski ArturKrasinski marked this pull request as ready for review December 2, 2024 15:36
@ArturKrasinski ArturKrasinski merged commit 9e5addb into new-doc-structure Dec 2, 2024
@ArturKrasinski ArturKrasinski deleted the ak/fix-card-links branch December 2, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants