Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add live example index pages for primitive components PTL-0 #1992

Merged
merged 18 commits into from
Dec 2, 2024

Conversation

matteematt
Copy link
Contributor

@matteematt matteematt commented Nov 29, 2024

  • Change the index pages for forms, presentation, and interaction to have cards with live examples
  • Add some react hooks to help with the index pages
  • Updates the css around the sidebar size, so it shrinks a bit when there is a small screen
  • Changes some components to render less information (or different styling) when the live example is part of the index
  • Changes some components to know when they're squished small and to change what they're rendering

@matteematt matteematt changed the title DRAFT WIP: live example pages feat: add live example index pages for primitive components PTL-0 Dec 2, 2024
@matteematt matteematt marked this pull request as ready for review December 2, 2024 10:28
position: 'relative',
width: '80px',
height: '80px',
margin: '0 auto',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation

Copy link
Contributor

@patrickoneill-genesis patrickoneill-genesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all is looking great. Only little nitpick I have is if you clicking an image within a card doesn't redirect. You have to click anywhere inside the card but not the image.

@patrickoneill-genesis
Copy link
Contributor

@matteematt suggest we look at the clicking on image issue in a separate PR

@matteematt matteematt merged commit 4028a9b into new-doc-structure Dec 2, 2024
@matteematt matteematt deleted the mw/PTL-0-live-example-summary-pages branch December 2, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants