-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add live example index pages for primitive components PTL-0 #1992
feat: add live example index pages for primitive components PTL-0 #1992
Conversation
matteematt
commented
Nov 29, 2024
•
edited
Loading
edited
- Change the index pages for forms, presentation, and interaction to have cards with live examples
- Add some react hooks to help with the index pages
- Updates the css around the sidebar size, so it shrinks a bit when there is a small screen
- Changes some components to render less information (or different styling) when the live example is part of the index
- Changes some components to know when they're squished small and to change what they're rendering
…-live-example-summary-pages
position: 'relative', | ||
width: '80px', | ||
height: '80px', | ||
margin: '0 auto', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and all is looking great. Only little nitpick I have is if you clicking an image within a card doesn't redirect. You have to click anywhere inside the card but not the image.
@matteematt suggest we look at the clicking on image issue in a separate PR |