PTL-1546 criteria matching #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickoneill-genesis
requested review from
skawian,
SzymonZur and
matteematt
patrickoneill-genesis
requested review from
wjhendry and
jay-taylerson
as code owners
matteematt
reviewed
Nov 29, 2024
Comment on lines
7
to
11
| - web | ||
| - criteria | ||
| - foundation criteria | ||
| - frontend | ||
| - ui |
There was a problem hiding this comment.
Can you add more tags and keywords to all these pages (groovy etc.). Can use AI to help I find. We want to have more keywords to aid searchability in docs
There was a problem hiding this comment.
Can you either turn this page into the index page to match the format of the other documents please? Or if not just get rid of the index page for this module and just link to the API docs from here
There was a problem hiding this comment.
Changed to index.mdx and moved the generated one to docs/index.mdx
docs/001_develop/03_client-capabilities/011_criteria/02_criteria-builder.mdx
Outdated
Show resolved
Hide resolved
docs/001_develop/03_client-capabilities/011_criteria/03_expression-buillder.mdx
Show resolved
Hide resolved
docs/001_develop/03_client-capabilities/011_criteria/02_criteria-builder.mdx
Show resolved
Hide resolved
docs/001_develop/03_client-capabilities/011_criteria/03_expression-buillder.mdx
Show resolved
Hide resolved
docs/001_develop/03_client-capabilities/011_criteria/04_form-criteria-builder.mdx
Outdated
Show resolved
Hide resolved
patrickoneill-genesis
changed the title
patrickoneill-genesis
changed the title
Co-authored-by: Matt Walker <43502076+matteematt@users.noreply.github.com>
# Conflicts: # plugins/api-docs/dist/manifest.js # plugins/api-docs/src/manifest.ts
matteematt
reviewed
Dec 2, 2024
matteematt
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for criteria matching. Really not fully certain what we should write for this.
In my opinion, it's just a Groovy expression string generator to create criteria strings to use with Charts, Grids, Entity management and connect snapshot/stream
The module itself is not well documented either