Draft - Framework integration #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickoneill-genesis
requested review from
wjhendry and
jay-taylerson
as code owners
matteematt
reviewed
Nov 29, 2024
docs/001_develop/03_client-capabilities/022_framework-integration/index.mdx
Outdated
Show resolved
Hide resolved
docs/001_develop/03_client-capabilities/022_framework-integration/index.mdx
Outdated
Show resolved
Hide resolved
docs/001_develop/03_client-capabilities/022_framework-integration/index.mdx
Outdated
Show resolved
Hide resolved
docs/001_develop/03_client-capabilities/022_framework-integration/002_integration-angular.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| Attributes are part of the HTML markup of an element and are reflected in the dom. | ||
|
|
||
| Attributes can be either hard coded or set using Angular's property event bindings. Note, any automatically maps hyphenated attribute names to camelCase property names so a property called `max-rows` becomes `maxRows`. |
There was a problem hiding this comment.
"Note, any automatically maps hyphenated attribute names to camelCase property" this sentence doesn't sound correct
docs/001_develop/03_client-capabilities/022_framework-integration/002_integration-angular.mdx
Show resolved
Hide resolved
docs/001_develop/03_client-capabilities/022_framework-integration/003_integration-react.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Basically the same comments I left on the Angular page apply here too
…ion/index.mdx Co-authored-by: Matt Walker <43502076+matteematt@users.noreply.github.com>
…ion/index.mdx Co-authored-by: Matt Walker <43502076+matteematt@users.noreply.github.com>
…ion/002_integration-angular.mdx Co-authored-by: Matt Walker <43502076+matteematt@users.noreply.github.com>
…ion/003_integration-react.mdx Co-authored-by: Matt Walker <43502076+matteematt@users.noreply.github.com>
matteematt
reviewed
Nov 29, 2024
docs/001_develop/03_client-capabilities/022_framework-integration/002_integration-angular.mdx
Outdated
Show resolved
Hide resolved
docs/001_develop/03_client-capabilities/022_framework-integration/002_integration-angular.mdx
Show resolved
Hide resolved
…ion/002_integration-angular.mdx Co-authored-by: Matt Walker <43502076+matteematt@users.noreply.github.com>
…ion/002_integration-angular.mdx Co-authored-by: Matt Walker <43502076+matteematt@users.noreply.github.com>
# Conflicts: # docs/001_develop/03_client-capabilities/022_framework-integration/002_integration-angular.mdx # docs/001_develop/03_client-capabilities/022_framework-integration/003_integration-react.mdx # docs/001_develop/03_client-capabilities/022_framework-integration/index.mdx
matteematt
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for framework integration. Will add styling sections when genta is finished