Chore - adding examples, testing react angular #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickoneill-genesis
requested review from
wjhendry and
jay-taylerson
as code owners
patrickoneill-genesis
changed the title
matteematt
reviewed
Nov 21, 2024
| @@ -50,16 +50,16 @@ Usage | |||
| template: html` | |||
| <rapid-checkbox | |||
| ?disabled="${(x) => x.disabled}" | |||
| ?checked="${sync((x) => x.isSelected, 'boolean')}" | |||
| @change="${(x) => x.checkChanged()}" | |||
| @change="${(x, ctx) => x.checkChanged(ctx.event)}" | |||
There was a problem hiding this comment.
Can we leave sync in this example please. If you want to show off the event version you can leave that too and comment on the funciton saying it's a choice
There was a problem hiding this comment.
I feel there are too many examples here, these extra examples would be suited more towards storybook
matteematt
approved these changes
Nov 22, 2024
Comment on lines
67
to
70
|
|
||
| const [switchValue, setSwitchValue] = useState(false); | ||
|
|
||
|
|
There was a problem hiding this comment.
Any
Suggested change
| const [switchValue, setSwitchValue] = useState(false); | |
| const [switchValue, setSwitchValue] = useState(false); |
Comment on lines
109
to
111
|
|
||
| switchValue: boolean; | ||
|
|
There was a problem hiding this comment.
Suggested change
| switchValue: boolean; | |
| switchValue: boolean; |
# Conflicts: # docs/001_develop/03_client-capabilities/007_forms/003_form-inputs/text-field.mdx # docs/001_develop/03_client-capabilities/007_forms/004_form-layout/criteria-segmented-control.mdx
# Conflicts: # examples/ui/client-capabilities/interaction/text-field.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATTENTION! NEW DOCS STRUCTURE
FOR THE NEXT THREE WEEKS, ONLY BRANCH FROM new-docs-structure
OTHERWISE, WAIT UNTIL THE NEW STRUCTURE HAS BEEN RELEASED
Thank you for contributing to the documentation.
Do the changes you have made apply to both Current and Previous versions?
Have you done a trial build to check all new or changed links?
Is there anything else you would like us to know?
This week's exciting advice from the style guide
Write your headings in sentence case:
This is a correct heading.
This is not a correct heading.