Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added custom components #1910

Merged
merged 11 commits into from
Dec 2, 2024
Merged

Conversation

gentaDemnushaj
Copy link
Contributor

@gentaDemnushaj gentaDemnushaj commented Nov 19, 2024

ATTENTION! NEW DOCS STRUCTURE
FOR THE NEXT THREE WEEKS, ONLY BRANCH FROM new-docs-structure
OTHERWISE, WAIT UNTIL THE NEW STRUCTURE HAS BEEN RELEASED


Thank you for contributing to the documentation.

Do the changes you have made apply to both Current and Previous versions?

Have you done a trial build to check all new or changed links?

Is there anything else you would like us to know?

This week's exciting advice from the style guide

  • Write your headings in sentence case:

    • A good example
      This is a correct heading.
    • A Bad Example
      This is not a correct heading.

@gentaDemnushaj gentaDemnushaj marked this pull request as ready for review November 21, 2024 18:10
@gentaDemnushaj gentaDemnushaj changed the title gd/custom elements docs: added custom components Nov 21, 2024
@gentaDemnushaj gentaDemnushaj self-assigned this Nov 22, 2024
@gentaDemnushaj gentaDemnushaj marked this pull request as draft November 22, 2024 18:51
@gentaDemnushaj gentaDemnushaj marked this pull request as ready for review November 27, 2024 13:52
Copy link
Contributor

@matteematt matteematt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an index file which is blank which you can get rid of

Apart from that really great work 🚀 Left a number of comments but they should mostly be quick fixes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page is missing an explanation of css parts. But if you think it'll take too long to do we can merge this and come back to it later

@matteematt matteematt merged commit 78020d4 into new-doc-structure Dec 2, 2024
@matteematt matteematt deleted the gd/custom-elements branch December 2, 2024 12:58
@matteematt
Copy link
Contributor

I have fixed all of the trivial fixes (marking them as done on github) and merging it. We can come back to those two slightly larger points later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants