upgrade to v4 github actions and bun for dependency installation #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-genesis
force-pushed
the
bun-ci
branch
7 times, most recently
from
c5c7007 to
aadcb2b
Compare
nick-genesis
changed the title
nick-genesis
requested review from
wjhendry,
dbarros1979 and
GuiWar
as code owners
GuiWar
reviewed
Jun 6, 2024
dbarros1979
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency installation is much faster with bun, ~1m 23s
For the actual build it doesn't make a difference since bun is using node for it under the hood, and if you force it with
--bunit breaks, so sticking withnpm run buildAlso upgraded github actions from v2 to v4 although don't expect to see much of a difference from that.