Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relocate chalk to packages FUI-1722 #85

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

derekdon
Copy link
Contributor

📷   Samples

NA

📓   Related Issue
If this PR is related to an issue then link it here, or delete this section.

🤔   What does this PR do?

  • Relocate the chalk dependency to each package.

📑   How should this be tested?

Update test steps to match your PR:

1. Checkout branch
2. `npm run bootstrap`
3. `npm run test`

Other packages are completely tested via tests from `npm run test`. To test the LSP is working correctly in VSCode:
1. `cd packages/showcase/example`
2. `code .` (or manually open VSCode via the UI to the `example` directory on your filesystem).
3. Open a typescript file such as `root.ts`
4. In the Command Palette choose `TypeScript: select typescript version...` and then choose the workspace version
5. The LSP should be enabled. You will need to make a code change after the LSP is enabled before you see any Intellisense.

✅   Checklist

  • [] I have added tests for my changes.
  • I have updated the project documentation.
  • I have followed the contribution guidelines.

@derekdon derekdon merged commit c63e1e3 into master Dec 20, 2023
1 check passed
@derekdon derekdon deleted the derekdon/relocate-chalk branch December 20, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants