Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort directionality button on table not working #39

Open
vanaukenk opened this issue Sep 9, 2024 · 5 comments
Open

Sort directionality button on table not working #39

vanaukenk opened this issue Sep 9, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@vanaukenk
Copy link

vanaukenk commented Sep 9, 2024

The sort directionality button on the table only allows sorting from A->Z, not the other way around, i.e. Z->A.

We should either remove that button, or implement the Z->A option.

Also, is it possible to preserve the field the curator selected for sorting in the sort list menu? Right now, regardless of what is selected, the display shows Gene Product (default).

@vanaukenk
Copy link
Author

Thanks @tmushayahama
I tested each of the fields for which sorting is available and they all appear to be working correctly with the exception of GO term aspect, which I couldn't make sense of in this model:
http://noctua-dev.berkeleybop.org/workbench/noctua-standard-annotations/?model_id=gomodel:66c64f3300000082

@vanaukenk vanaukenk moved this from Todo to Testing - noctua-dev in Noctua form refactor concealing GO-CAM model Sep 12, 2024
@vanaukenk
Copy link
Author

Use root type to sort on GO aspect?

@vanaukenk
Copy link
Author

vanaukenk commented Dec 2, 2024

@tmushayahama - sorting on GO term aspect is still not working. It would be nice to be able to do this, but if we can't, I'd suggest just removing that sort option from the list for now.

@vanaukenk vanaukenk moved this from Testing - noctua-dev to Ready for production in Noctua form refactor concealing GO-CAM model Dec 19, 2024
@vanaukenk
Copy link
Author

vanaukenk commented Dec 19, 2024

@tmushayahama - this is generally working fine on production, but some small tweaks would be good:

  1. Remove the GO term aspect sorting option from the menu, as this isn't working
  2. Align the order and names of the sortable columns in the menu with the order and names of columns in the table

@vanaukenk
Copy link
Author

Noting that this was updated with sorting on the actual column header rather than a separate sorting selection menu as initially implemented.

@vanaukenk vanaukenk moved this from Testing - noctua-dev to Ready for production in Noctua form refactor concealing GO-CAM model Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants