Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update retracted-publications.txt #2450

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Update retracted-publications.txt #2450

merged 1 commit into from
Mar 5, 2025

Conversation

pgaudet
Copy link
Contributor

@pgaudet pgaudet commented Mar 4, 2025

No description provided.

@pgaudet pgaudet requested a review from kltm March 4, 2025 09:02
@kltm
Copy link
Member

kltm commented Mar 4, 2025

@pgaudet The diff is too large to review here. It would probably be better to get @mugitty to review this one, as she is more familiar with the operative code.

@pgaudet
Copy link
Contributor Author

pgaudet commented Mar 5, 2025

There is no code - this is just the list of retracted publications, updated yesterday.

@pgaudet
Copy link
Contributor Author

pgaudet commented Mar 5, 2025

However - I think this was failing because of that build problem. If not, we can merge this, the only problem it may cause is that the publications list for GORULE:0000022 Check for, and filter, annotations made to retracted publications would be missing... this is not used anywhere else.

@kltm
Copy link
Member

kltm commented Mar 5, 2025

@pgaudet If you don't think a review is needed, you can go ahead and merge.

@pgaudet
Copy link
Contributor Author

pgaudet commented Mar 5, 2025

The error message is

note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

I though this was the broader problem... ?

@pgaudet
Copy link
Contributor Author

pgaudet commented Mar 5, 2025

thanks ! I didn't like the error so much.

@pgaudet pgaudet merged commit f68f191 into master Mar 5, 2025
1 of 2 checks passed
@pgaudet pgaudet deleted the pgaudet-patch-947485 branch March 5, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants