Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change https-> http to match minerva URI expansion for SGD #2176

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Conversation

sierra-moxon
Copy link
Member

@sierra-moxon sierra-moxon commented Nov 15, 2023

see https://github.com/geneontology/go-fastapi #87

GO-API expands SGD:S000003407 to https://identifiers.org/sgd/S000003407 using the go.csv context in prefixmaps. go.csv context in prefixmaps is generated by pulling in the rdf_uri_prefix from the db-xrefs.yaml. Since the URL generated from minerva in the model is http://identifiers.org/sgd/S000003407 (note the http vs, https), no results are returned from the GO-API query.

Is this the right approach @balhoff ?

@kltm
Copy link
Member

kltm commented Nov 16, 2023

This can be merged with the agreement of @balhoff or @cmungall

Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is true for this specific case, but what about:

sjcarbon@moiraine:~/local/src/git/go-site/metadata[master]$:) grep 'https://identifiers.org' db-xrefs.yaml 
  rdf_uri_prefix: https://identifiers.org/maizegdb.locus
  rdf_uri_prefix: https://identifiers.org/metacyc.reaction
  rdf_uri_prefix: https://identifiers.org/MGI
  rdf_uri_prefix: https://identifiers.org/ncbigene
  rdf_uri_prefix: https://identifiers.org/panther.family
  rdf_uri_prefix: https://identifiers.org/plasmodb
  rdf_uri_prefix: https://identifiers.org/pombase
  rdf_uri_prefix: https://identifiers.org/reactome
  rdf_uri_prefix: https://identifiers.org/rgd
  rdf_uri_prefix: https://identifiers.org/sgd
  rdf_uri_prefix: https://identifiers.org/sgn
  rdf_uri_prefix: https://identifiers.org/tair.locus
  rdf_uri_prefix: https://identifiers.org/tgd
  rdf_uri_prefix: https://identifiers.org/tritrypdb
  rdf_uri_prefix: https://identifiers.org/uniprot
  rdf_uri_prefix: https://identifiers.org/wb
  rdf_uri_prefix: https://identifiers.org/xenbase
  rdf_uri_prefix: https://identifiers.org/zfin

I would assume this is a uniform problem? @sierra-moxon

metadata/db-xrefs.yaml Outdated Show resolved Hide resolved
@kltm
Copy link
Member

kltm commented Nov 16, 2023

sjcarbon@moiraine:~/local/src/git/noctua-models/models[master]$:( cat *.ttl | grep -c "http://registry.identifiers.org"
0
sjcarbon@moiraine:~/local/src/git/noctua-models/models[master]$:( cat *.ttl | grep -c "http://identifiers.org"
211694
sjcarbon@moiraine:~/local/src/git/noctua-models/models[master]$:) cat *.ttl | grep -c "https://identifiers.org"
0

@kltm
Copy link
Member

kltm commented Nov 16, 2023

TODO: add trailing slashes and the above identifiers.

@sierra-moxon
Copy link
Member Author

I tested these changes via the API and I think they are good to go w/re to expanding SGD curies. I noticed an expansion problem with wormbase beyond the https issue, and changed it to be equivalent to https://github.com/geneontology/minerva/blob/master/minerva-core/src/main/resources/go_context.jsonld instead.
Same with interpro

@sierra-moxon sierra-moxon requested a review from balhoff November 28, 2023 23:31
@kltm
Copy link
Member

kltm commented Jul 17, 2024

Noting @balhoff approval above; following up on #2176 (comment)

@kltm kltm merged commit 13179f0 into master Jul 17, 2024
2 checks passed
@kltm
Copy link
Member

kltm commented Jul 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants