-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change https-> http to match minerva URI expansion for SGD #2176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is true for this specific case, but what about:
sjcarbon@moiraine:~/local/src/git/go-site/metadata[master]$:) grep 'https://identifiers.org' db-xrefs.yaml
rdf_uri_prefix: https://identifiers.org/maizegdb.locus
rdf_uri_prefix: https://identifiers.org/metacyc.reaction
rdf_uri_prefix: https://identifiers.org/MGI
rdf_uri_prefix: https://identifiers.org/ncbigene
rdf_uri_prefix: https://identifiers.org/panther.family
rdf_uri_prefix: https://identifiers.org/plasmodb
rdf_uri_prefix: https://identifiers.org/pombase
rdf_uri_prefix: https://identifiers.org/reactome
rdf_uri_prefix: https://identifiers.org/rgd
rdf_uri_prefix: https://identifiers.org/sgd
rdf_uri_prefix: https://identifiers.org/sgn
rdf_uri_prefix: https://identifiers.org/tair.locus
rdf_uri_prefix: https://identifiers.org/tgd
rdf_uri_prefix: https://identifiers.org/tritrypdb
rdf_uri_prefix: https://identifiers.org/uniprot
rdf_uri_prefix: https://identifiers.org/wb
rdf_uri_prefix: https://identifiers.org/xenbase
rdf_uri_prefix: https://identifiers.org/zfin
I would assume this is a uniform problem? @sierra-moxon
|
TODO: add trailing slashes and the above identifiers. |
Co-authored-by: Jim Balhoff <jim@balhoff.org>
I tested these changes via the API and I think they are good to go w/re to expanding SGD curies. I noticed an expansion problem with wormbase beyond the https issue, and changed it to be equivalent to https://github.com/geneontology/minerva/blob/master/minerva-core/src/main/resources/go_context.jsonld instead. |
Noting @balhoff approval above; following up on #2176 (comment) |
see https://github.com/geneontology/go-fastapi #87
GO-API expands
SGD:S000003407
tohttps://identifiers.org/sgd/S000003407
using thego.csv
context in prefixmaps.go.csv
context in prefixmaps is generated by pulling in therdf_uri_prefix
from the db-xrefs.yaml. Since the URL generated from minerva in the model ishttp://identifiers.org/sgd/S000003407
(note thehttp
vs,https
), no results are returned from the GO-API query.Is this the right approach @balhoff ?