Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty lines in sample config #24

Open
yunesj opened this issue Aug 8, 2017 · 5 comments
Open

Empty lines in sample config #24

yunesj opened this issue Aug 8, 2017 · 5 comments

Comments

@yunesj
Copy link
Contributor

yunesj commented Aug 8, 2017

rofs-filtered.rc has empty lines. It was necessary for me to comment these empty lines out in my own config on rofs-filtered: stable 1.7 (bottled) installed via brew.

@gburca
Copy link
Owner

gburca commented Aug 9, 2017

There's no need to comment out empty lines. They are explicitly ignored as long as they are truly empty (or contain only whitespace). Can you post an example of a config file that I can use to reproduce the problem?

@yunesj
Copy link
Contributor Author

yunesj commented Aug 9, 2017

Sure. But it will take a little while for me to get around to this (for this issue and the other), because I'm actively using a rofs-filtered mount.

@yunesj
Copy link
Contributor Author

yunesj commented May 15, 2018

# cat rofs-filtered.rc

Guest

gives me:

RegEx error: "empty (sub)expression" while parsing pattern: ""

However,

# cat rofs-filtered.rc
Guest

works perfectly.

It seems like this is just a warning, and the file system works fine and filters correctly.

Thanks!

@gburca
Copy link
Owner

gburca commented May 16, 2018

I can't seem to reproduce this issue. I tried all kinds of line endings, and lines with tabs or spaces (see
rofs-filtered.txt for example), and they all seem to work fine. Can you attach your config file?

@yunesj
Copy link
Contributor Author

yunesj commented May 17, 2018

I get the same warning using your config file.

# rofs-filtered /Volumes/Filtered/ -o source=/ -o config=rofs-filtered.txt
rofs-filtered 1.7: Starting up. Using source: / and config: rofs-filtered.txt
RegEx error: "empty (sub)expression" while parsing pattern: ""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants