From e7ef1d01f6f14997d47b846bc876e7ff959798cf Mon Sep 17 00:00:00 2001 From: proll Date: Fri, 5 Dec 2014 12:06:38 +0300 Subject: [PATCH 1/2] make removeSelectors and hideSelectors fo their job on each Element - not only the ffirst --- capture/genBitmaps.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/capture/genBitmaps.js b/capture/genBitmaps.js index 2fd6e10a1..3082b192b 100644 --- a/capture/genBitmaps.js +++ b/capture/genBitmaps.js @@ -80,14 +80,18 @@ function capturePageSelectors(url,grabConfigs,viewports,bitmaps_reference,bitmap //HIDE SELECTORS WE WANT TO AVOID grabConfig.hideSelectors.forEach(function(o,i,a){ casper.evaluate(function(o){ - document.querySelector(o).style.visibility='hidden'; + document.querySelectorAll(o).forEach(function(s){ + s.style.visibility='hidden'; + }); },o); }); //REMOVE UNWANTED SELECTORS FROM RENDER TREE grabConfig.removeSelectors.forEach(function(o,i,a){ casper.evaluate(function(o){ - document.querySelector(o).style.display='none'; + document.querySelectorAll(o).forEach(function(s){ + s.style.display='none'; + }); },o); }); From 900d2f5f5e47a1e4b6493fa6b687f2c32afe009f Mon Sep 17 00:00:00 2001 From: proll Date: Fri, 5 Dec 2014 18:12:46 +0300 Subject: [PATCH 2/2] fix iterator --- capture/genBitmaps.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/capture/genBitmaps.js b/capture/genBitmaps.js index 3082b192b..f8f93a4b8 100644 --- a/capture/genBitmaps.js +++ b/capture/genBitmaps.js @@ -80,7 +80,7 @@ function capturePageSelectors(url,grabConfigs,viewports,bitmaps_reference,bitmap //HIDE SELECTORS WE WANT TO AVOID grabConfig.hideSelectors.forEach(function(o,i,a){ casper.evaluate(function(o){ - document.querySelectorAll(o).forEach(function(s){ + Array.prototype.forEach.call(document.querySelectorAll(o), function(s, j){ s.style.visibility='hidden'; }); },o); @@ -89,12 +89,12 @@ function capturePageSelectors(url,grabConfigs,viewports,bitmaps_reference,bitmap //REMOVE UNWANTED SELECTORS FROM RENDER TREE grabConfig.removeSelectors.forEach(function(o,i,a){ casper.evaluate(function(o){ - document.querySelectorAll(o).forEach(function(s){ + Array.prototype.forEach.call(document.querySelectorAll(o), function(s, j){ s.style.display='none'; }); },o); }); - + //CREATE SCREEN SHOTS AND TEST COMPARE CONFIGURATION (CONFIG FILE WILL BE SAVED WHEN THIS PROCESS RETURNS) grabConfig.selectors.forEach(function(o,i,a){ var cleanedSelectorName = o.replace(/[^a-zA-Z\d]/,'');//remove anything that's not a letter or a number