-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set package search paths independently from GAP roots #933
Conversation
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
==========================================
- Coverage 74.6% 74.6% -0.01%
==========================================
Files 481 481
Lines 242402 242427 +25
==========================================
+ Hits 180851 180858 +7
- Misses 61551 61569 +18
|
I think this may be useful - for example, this would make life easier when one runs GAP docker container and would like to load GAP package from their local filesystem. I suggest to review this in order to include in GAP 4.9. |
cd00791
to
92db1db
Compare
To finish this, there should also be a command line option similar to |
d5d2496
to
088b1c0
Compare
e4d8d2e
to
92e723b
Compare
@fingolfin this seems not be ready for GAP 4.9.0 - let's postpone to some future milestone. |
@alex-konovalov well, you added that milestone, I never had that in mind :-). Removed it. |
@fingolfin ok. That was just an "add that milestone to remind us to review the status of this PR before making GAP 4.9 beta" intention. |
This is a first step towards allowing package directories to be specified independently from GAP root paths.
82c945b
to
67310a1
Compare
Closing in favor of PR #5873 |
This is work-in-progress code which I started in February, but then got sidetracked, and never completed.
Before I invest more effort into it, I thought I should ask what people think about this...
This PR is about changing GAP to tracker "package search directories" separately from "GAP roots"
The idea is that I would like to be able to tell GAP to load packages from a specific dir, and not just from a "foo/pkg/my-actual-package", where "foo" must be a GAP root, and "pkg" is fixed (GAP insists on it). Instead, I'd like to be able to just point GAP at a directory "foo", and it automaticaly picks up any packages in there -- regardless of whether "foo" itself is the directory of a package, or "foo" contains packages (such as "foo/cvec", "foo/orb", ...).
Of course one can still specify GAP roots; internally, when you specify a GAP root "foo", then GAP simply adds "foo/pkg" to the list of package search directories. But in addition, users should be able to specify package search directories which are not within a GAP root. Either by calling the GAP function
ExtendPackageDirectories()
, or by specifying a command line flag (the latter has not yet been implemented).Of course if anybody is interested in this, feel free to help work on it... or just give feedback... :)