Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editorconfig: don't remove trailing whitespace in XML files #5920

Merged
merged 1 commit into from
Jan 28, 2025
Merged

editorconfig: don't remove trailing whitespace in XML files #5920

merged 1 commit into from
Jan 28, 2025

Conversation

fingolfin
Copy link
Member

GAPDoc XML may contain .tst data with relevant trailing whitespace, so don't touch those.

Resolves #5689

@fingolfin
editorconfig: don't remove trailing whitespace in XML files
40165a1 
GAPDoc XML may contain .tst data with relevant trailing whitespace,
so don't touch those.
@fingolfin fingolfin added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Jan 28, 2025
ThomasBreuer
ThomasBreuer approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Yes, this solves the problem from the underlying issue.

(Still I do not like the whole idea that after I have modified a file, the editor comes along and makes changes which I did not want to make.)

@fingolfin fingolfin merged commit a16feca into gap-system:master Jan 28, 2025
31 of 33 checks passed
@fingolfin fingolfin deleted the mh/trailing-whitespace-in-xml branch January 28, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBreuer ThomasBreuer ThomasBreuer approved these changes

Assignees
No one assigned
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trim trailing whitespace?
2 participants
@fingolfin @ThomasBreuer