De-duplicate some functions #5657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-d-mitchell
added
the
release notes: not needed
fingolfin
reviewed
Feb 27, 2024
| fi; | ||
| return r; | ||
| end); | ||
| [IsObjWithMemory],0, OneOp); |
There was a problem hiding this comment.
This ends up performing a second method dispatch, though, doesn't it? And hence would make this a tiny bit slower...
There was a problem hiding this comment.
True, but is it likely to be critical anywhere? I can reverse this if desirable.
…Memory As per the manual entry for One etc, the OneImmutable(=One) method calls the OneMutable(=OneOp) method.
Co-authored-by: Max Horn <max@quendi.de>
james-d-mitchell
force-pushed
the
de-duplicate
branch
from
15e1033 to
51d12dd
Compare
fingolfin
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some more refactoring of the GAP library code to remove duplicate functions. The functions touched in this PR have identical function bodies (up to whitespace).