Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_Thread_local specifiers in Cyclotomic function #5547

Closed
wants to merge 2 commits into from

Conversation

nskeip
Copy link
Contributor

@nskeip nskeip commented Dec 17, 2023

This solves possible race condition (issue #5110) using C11 feature.

Text for release notes

none

This solves possible race condition (issue 5110) using C11 feature.
@dimpase
Copy link
Member

dimpase commented Dec 17, 2023

since when is GAP running on native Windows?

@fingolfin
Copy link
Member

thanks for your contribution. Alas, for now we are still using C99 not C11 (I am open to reopening this decision next year, but not as a side effect for a minor PR).
That said, I also think it would be better to just move these variables into our existing TLS structure (IIRC defined in src/hpc/tls.h)

@nskeip
Copy link
Contributor Author

nskeip commented Dec 17, 2023

thanks for your contribution. Alas, for now we are still using C99 not C11 (I am open to reopening this decision next year, but not as a side effect for a minor PR). That said, I also think it would be better to just move these variables into our existing TLS structure (IIRC defined in src/hpc/tls.h)

Thanks for the feedback! I agree that placing the variables to TLS is more appropriate.

@nskeip nskeip closed this Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants