Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three small fixes from working with U4(3) #5545

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Three small fixes from working with U4(3) #5545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81ffa1e
FIX: Action through smaller degree
hulpke Dec 13, 2023
a8ecdba
FIX: Rewriting system for extensions
hulpke Dec 13, 2023
0d26920
FIX: ExponentsSumWord for SLP elements
hulpke Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/gpfpiso.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ function(g,str,N)
od;
if Size(ser[1])<Size(f) then
ser:=ChiefSeriesThrough(f,ser);
gens:=Union(gens,Union(List(ser,SmallGeneratingSet)));
fi;
if f<>g then
gens:=List(gens,x->PreImagesRepresentative(hom,x));
Expand All @@ -300,6 +301,7 @@ function(g,str,N)
else
rad:=g;
fi;

if Length(ser)=0 or Size(ser[Length(ser)])>Size(rad) then Add(ser,rad);fi;

if Size(rad)>1 then
Expand Down Expand Up @@ -479,6 +481,7 @@ function(g,str,N)
vals:=[];

dec:=[];

for i in [2..Length(ser)] do
still:=i<Length(ser);
lgens:=gens{idx[i-1]};
Expand Down
8 changes: 4 additions & 4 deletions lib/oprtglat.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,11 +468,11 @@
#and NrMovedPoints(G)*1000>Size(G) then

b:=SmallerDegreePermutationRepresentation(G:cheap);
if NrMovedPoints(Range(b))<NrMovedPoints(G) then
dom:=SubgroupsOrbitsAndNormalizers(Image(b,G),
if NrMovedPoints(Range(b))*13/10<NrMovedPoints(G) then
l:=SubgroupsOrbitsAndNormalizers(Image(b,G),

Check warning on line 472 in lib/oprtglat.gi

View check run for this annotation

Codecov / codecov/patch

lib/oprtglat.gi#L471-L472 

Added lines #L471 - L472 were not covered by tests
List(dom,x->Image(b,x)),all);
dom:=List(dom,x->rec(pos:=x.pos,normalizer:=PreImage(b,x.normalizer),
representative:=dom[x]));
dom:=List(l,x->rec(pos:=x.pos,normalizer:=PreImage(b,x.normalizer),
representative:=dom[x.pos]));

Check warning on line 475 in lib/oprtglat.gi

View check run for this annotation

Codecov / codecov/patch

lib/oprtglat.gi#L474-L475 

Added lines #L474 - L475 were not covered by tests
return dom;
fi;
fi;
Expand Down
11 changes: 11 additions & 0 deletions lib/straight.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2059,6 +2059,17 @@
);
end);

#############################################################################
##
#M ExponentSumWord
##
InstallMethod(ExponentSumWord,"for a straight line program word",
IsIdenticalObj, [IsAssocWord and IsStraightLineProgElm,IsAssocWord],0,
function(slp,e)
return ExponentSumWord(EvalStraightLineProgElm(slp),
EvalStraightLineProgElm(e));

Check warning on line 2070 in lib/straight.gi

View check run for this annotation

Codecov / codecov/patch

lib/straight.gi#L2069-L2070 

Added lines #L2069 - L2070 were not covered by tests
end);

# words represented as tree elements (those are useful for decoding subgroup
# presentations)

Expand Down