Skip to content

Commit

Permalink
Change Cite to not include a version in the generated keys (#5653)
Browse files Browse the repository at this point in the history
  • Loading branch information
fingolfin authored Feb 26, 2024
1 parent 4a5bf41 commit 8fe588d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
4 changes: 1 addition & 3 deletions lib/package.gi
Original file line number Diff line number Diff line change
Expand Up @@ -2718,9 +2718,7 @@ InstallGlobalFunction( BibEntry, function( arg )

if key = false then
if GAP then
key:= Concatenation( "GAP", GAPInfo.Version );
elif IsBound( pkginfo.Version ) then
key:= Concatenation( pkginfo.PackageName, pkginfo.Version );
key:= "GAP";
else
key:= pkginfo.PackageName;
fi;
Expand Down
8 changes: 4 additions & 4 deletions tst/testinstall/package.tst
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ HTML:

BibXML:

<entry id="mockpkg0.1"><misc>
<entry id="mockpkg"><misc>
<author>
<name><first>Active</first><last>Author</last></name>
<name><first>Retired</first><last>Author</last></name>
Expand All @@ -559,7 +559,7 @@ BibXML:

BibTeX:

@misc{ mockpkg0.1,
@misc{ mockpkg,
author = {Author, A. and Author, R. and Maintainer, O.},
title = {{mockpkg}, A mock package for use by the GAP test
suite, {V}ersion 0.1},
Expand Down Expand Up @@ -598,7 +598,7 @@ HTML:

BibXML:

<entry id="mockpkg0.1"><misc>
<entry id="mockpkg"><misc>
<author>
<name><first>Active</first><last>Author</last></name>
<name><first>Retired</first><last>Author</last></name>
Expand All @@ -614,7 +614,7 @@ BibXML:

BibTeX:

@misc{ mockpkg0.1,
@misc{ mockpkg,
author = {Author, A. and Author, R. and Maintainer, O.},
title = {{mockpkg}, A mock package for use by the GAP test
suite, {V}ersion 0.1},
Expand Down

0 comments on commit 8fe588d

Please sign in to comment.