Skip to content

Commit

Permalink
FIX: Ensure NewmanInfinityTest works
Browse files Browse the repository at this point in the history
and does not run into a error message because of generator number in the PQ.
Also some comments.
  • Loading branch information
hulpke committed Dec 8, 2023
1 parent 6241704 commit 7480972
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion lib/grpfp.gi
Original file line number Diff line number Diff line change
Expand Up @@ -5525,19 +5525,23 @@ local GO,q,d,e,b,r,val,agemo,ngens;
ngens:=32;
repeat
ngens:=ngens*8;
q:=PQuotient(G,p,2,ngens);
q:=PQuotient(G,p,2,ngens:noninteractive);
until q<>fail;
q:=Image(EpimorphismQuotientSystem(q));
# factor out G^p
q:=ShallowCopy(PCentralSeries(q,p));
if Length(q)=1 then
Error("Trivial <p> quotient");
fi;
if Length(q)=2 then
Add(q,q[2]); # maximal quotient is abelian, second term is trivial
fi;

d:=LogInt(Index(q[1],q[2]),p);

if p=2 then
# This case is taken from the book by Johnson, as Newman's paper only
# treats odd n.
e:=LogInt(Index(q[2],q[3]),p);
Info(InfoFpGroup,1,b," generators, ",r," relators, p=",p,", d=",d," e=",e);
q:=r-b+d;
Expand Down

0 comments on commit 7480972

Please sign in to comment.