Skip to content

Commit

Permalink
FIX: Overlooked case for cyclic MTC (#5532)
Browse files Browse the repository at this point in the history
When rewriting to cyclic subgroup words are just numbers, not lists. Thus
concatenation needs to be replaced by addition. This was overlooked in one
case.

Co-authored-by: Alexander Hulpke <hulpke@math.colostate.edu>
  • Loading branch information
fingolfin and hulpke authored Nov 17, 2023
1 parent 962db5c commit 27cdd4b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
7 changes: 6 additions & 1 deletion lib/sgpres.gi
Original file line number Diff line number Diff line change
Expand Up @@ -2847,7 +2847,12 @@ local c,offset,f,b,r,i,j,fp,bp;
od;
if i>r then
if f<>alpha then
NEWTC_ModifiedCoincidence(DATA,f,alpha,WordProductLetterRep(-Reversed(fp),y));
if DATA.useAddition then
NEWTC_ModifiedCoincidence(DATA,f,alpha,-fp+y);
else
NEWTC_ModifiedCoincidence(DATA,f,alpha,
WordProductLetterRep(-Reversed(fp),y));
fi;
fi;
return;
fi;
Expand Down
7 changes: 7 additions & 0 deletions tst/testbugfix/2023-10-28-GQuotients.tst
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Fix unexpected error in GQuotients.
# See https://github.com/gap-system/gap/issues/5525
#
gap> G := FreeGroup(2);;
gap> Q := G / [G.1*G.2^-2*G.1, G.1^-1*G.2^-3];;
gap> GQuotients(Q, SmallGroup(12, 1));
[ ]

0 comments on commit 27cdd4b

Please sign in to comment.