Move recent "Example" package tests to RecentGapOnly #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtorpey
added
the
bug in tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #139 +/- ##
==========================================
+ Coverage 86.39% 86.84% +0.45%
==========================================
Files 24 24
Lines 1110 1110
==========================================
+ Hits 959 964 +5
+ Misses 151 146 -5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 4.12 tests are failing due to the Example package not having an "accepted", "deposited", etc. status. This requirement has been relaxed in recent versions, so it's not something we're worried about going forward.
I've moved the offending tests to
RecentGapOnly.tst, which means it'll still be run on stable-4.14 and master, which are more forgiving.