Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some more tests #5

Open
markuspf opened this issue Dec 6, 2018 · 1 comment
Open

Add some more tests #5

markuspf opened this issue Dec 6, 2018 · 1 comment
Labels
enhancement New feature or request tests About tests for the package

Comments

@markuspf
Copy link
Member

markuspf commented Dec 6, 2018

No description provided.

@wilfwilson wilfwilson changed the title Some more tests Add some more tests Jul 27, 2021
@wilfwilson wilfwilson added enhancement New feature or request tests About tests for the package labels Jul 27, 2021
@wilfwilson
Copy link
Member

We have 100% code coverage now. I think we should try to maintain that as far as possible (this is encouraged by the use of the Codecov PR status checks, which fail is the diff is not 100% covered).

I also agree it would be nice to expand the tests so that we are testing a bigger variety of things, and also to add some more difficult tests that perhaps take a while (to act as an incentive to make things go faster).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request tests About tests for the package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markuspf @wilfwilson