V2 Migration #47

AndrewKahr · 2023-04-22T12:59:25Z

Changes

Rollback node-fetch version
Add test deployment
Use service account for deployment
Update node to 20 (Current version shuts down in 6 months)
Complete migration to v2 (Defaults to v2 in ~3 months)
Update packages

This should merge before working on fixing #48. Prior to merging, all existing functions will need to be deleted as updating to v2 cannot be done in place.

Checklist

Read the contribution guide and accept the code of conduct
Readme (updated or not needed)
Tests (added, updated or not needed)

AndrewKahr · 2023-04-22T13:00:44Z

@webbertakken Is there a way to test deployments in a workflow without actually deploying? The build workflow was a green light but the previous deployment failed.

webbertakken · 2023-04-22T13:26:30Z

@webbertakken Is there a way to test deployments in a workflow without actually deploying? The build workflow was a green light but the previous deployment failed.

Nowadays there is an action that does preview deployments for firebase. It wasn't there when I created this. I have in fact just set that up in another repo of mine and it works well (you would still need to do something based on the env so that the ingeminator code doesn't do stuff in prod though)

AndrewKahr · 2023-04-22T13:36:26Z

I assume you mean don't let the ingeminator do stuff in the preview deployments and only allow it in prod? Curious if you have any ideas off the top of your head on how to accomplish this.

Would you also be able to set up the service credentials as even if we don't use this action in the end, the one we currently use also complains about the login token being deprecated.

webbertakken · 2023-04-22T13:40:04Z

It does all of that stuff for you when you run firebase init. You have admin access to the project so you should be able able to provision the service account etc (it goes automatically).

And you can use https://github.com/webbertakken/brioso as reference if you like.

AndrewKahr · 2023-04-22T13:42:44Z

Wouldn't I need access to secrets on the versioning-backend repo to add the credential after running init? Or am I supposed to run init in a workflow on GitHub?

webbertakken · 2023-04-22T13:49:05Z

You have editor access in the project

edit: removed public email in screenshot

I'm not sure what you mean by needing access. Could you be very specific?

AndrewKahr · 2023-04-22T13:51:06Z

I assume I need to access the secrets tab in the repo settings to be able to add the service account credentials but I can't see the settings tab as an editor, I believe I would need maintainer level access.

webbertakken · 2023-04-22T13:58:40Z

No, you have to run firebase init and choose yes when it asks you to create a deployment workflow for you.

webbertakken · 2023-04-22T14:06:15Z

I have also given you maintainer access on the repo.

AndrewKahr · 2023-04-22T14:11:20Z

I'm getting this error:

? For which GitHub repository would you like to set up a GitHub workflow? (format: user/repository) game-ci/versioning-backend

Error: HTTP Error: 403, Policy update access denied.

It sounds like I need even more permissions? https://stackoverflow.com/questions/63995958/firebase-init-functions-returns-403-caller-does-not-have-permission

It may also only be possible for an owner to init based on this: https://stackoverflow.com/questions/74860122/firebase-init-hosinggithub-for-organization

webbertakken · 2023-04-22T16:18:31Z

Ok I've made you owner

AndrewKahr · 2023-04-22T23:36:19Z

The cleanup step claims there is an error deleting the artifact but manually going to the artifact page shows that it did indeed clean up the build artifact so I'm not sure what it's warning about. This should be ready to go now though

… Update packages

webbertakken

LGTM.

Just make sure we have a backup of the database before the modified cron starts

webbertakken · 2024-06-04T20:35:34Z

package.json

+  "devDependencies": {
+    "firebase-tools": "^13.10.2"


This should be installed as a global dependency as per the official docs

webbertakken · 2024-06-04T20:37:21Z

.github/workflows/main.yml

+  testDeploy:
+    name: Test Deploy
+    needs: [test, build]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: 'yarn'
+      - name: install dependencies
+        run: yarn && yarn --cwd ./functions
+      - name: Deploy test to Firebase
+        uses: w9jds/firebase-action@v13.10.2
+        with:
+          args: deploy --only functions:testFunction
+        env:
+          GCP_SA_KEY: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_UNITY_CI_VERSIONS }}'
+      - name: Cleanup Firebase Test
+        uses: w9jds/firebase-action@v13.10.2
+        with:
+          args: functions:delete testFunction --force
+        env:
+          GCP_SA_KEY: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_UNITY_CI_VERSIONS }}'


Do we still need this?

I would want to keep it as this is a great way to ensure the project will deploy properly for the actual functions since it requires roughly the same permissions as the main functions and has been setup to require all the secrets that the other functions might use as a deploy test

webbertakken · 2024-06-04T20:42:20Z

functions/src/service/discord.ts

-  }
-
-  static async becomeReady(): Promise<void> {
+  async becomeReady(): Promise<void> {


This is usually called init or create or getInstance, or made private and called from the constructor.

webbertakken · 2024-06-04T20:45:36Z

.github/workflows/main.yml

+          GCP_SA_KEY: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_UNITY_CI_VERSIONS }}'
+      - name: Cleanup Firebase Test
+        uses: w9jds/firebase-action@v13.10.2
+        with:
+          args: functions:delete testFunction --force
+        env:
+          GCP_SA_KEY: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_UNITY_CI_VERSIONS }}'


Better to use --except flag and deploy in a single transaction, than to later delete a partial deployment.

Fix issues discovered during deployment

679f933

AndrewKahr requested a review from webbertakken April 22, 2023 12:59

Fix compile issues

3c56b9d

Fix predeploy

4915b72

AndrewKahr added 13 commits April 22, 2023 14:26

Add test function deployment

d12b2ac

Fix linting

67e3480

Fix linting

db20947

Pin versions, add module to package type

e6a260e

Fix linting

843bd8a

Revert to commonjs

3cfea6d

Revert module resolution

8c1ce71

Fix missing token field

3f1171c

Remove token

97c06d3

Fix lint

f18e100

Revert node fetch version

cd6a9c9

Cleanup test function

0a6821a

Use force delete

7aba8d0

AndrewKahr requested review from webbertakken and removed request for webbertakken April 22, 2023 23:34

AndrewKahr added 11 commits June 4, 2024 00:35

Finish migration to v2 functions. Converts to new secrets management.…

6d93f00

… Update packages

Fix formatting

59f9247

Remove require

1e9e46a

Read file contents

abdc8e9

Downgrade node-fetch

cedc50a

Downgrade octokit

318af17

Verbose secret paths

2280e5e

Improve service account credential read

3478c03

Force service account credential

f605d87

Revert secret names

5d4219e

Add fallback path to service account credentials

42782bd

AndrewKahr requested review from davidmfinol and GabLeRoux June 4, 2024 09:59

AndrewKahr changed the title ~~Fix issues discovered during deployment~~ V2 Migration Jun 4, 2024

webbertakken approved these changes Jun 4, 2024

View reviewed changes

Fixes from code review. Docs on database backup/restore

a43b241

AndrewKahr merged commit bd3002f into main Jun 5, 2024
4 checks passed

AndrewKahr deleted the fix-deployment branch June 5, 2024 02:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V2 Migration #47

V2 Migration #47

AndrewKahr commented Apr 22, 2023 •

edited

Loading

AndrewKahr commented Apr 22, 2023

webbertakken commented Apr 22, 2023 •

edited

Loading

AndrewKahr commented Apr 22, 2023

webbertakken commented Apr 22, 2023 •

edited

Loading

AndrewKahr commented Apr 22, 2023

webbertakken commented Apr 22, 2023 •

edited by GabLeRoux

Loading

AndrewKahr commented Apr 22, 2023

webbertakken commented Apr 22, 2023

webbertakken commented Apr 22, 2023

AndrewKahr commented Apr 22, 2023 •

edited

Loading

webbertakken commented Apr 22, 2023

AndrewKahr commented Apr 22, 2023 •

edited

Loading

webbertakken left a comment

webbertakken Jun 4, 2024

webbertakken Jun 4, 2024

AndrewKahr Jun 5, 2024

webbertakken Jun 4, 2024

webbertakken Jun 4, 2024

V2 Migration #47

V2 Migration #47

Conversation

AndrewKahr commented Apr 22, 2023 • edited Loading

Changes

Checklist

AndrewKahr commented Apr 22, 2023

webbertakken commented Apr 22, 2023 • edited Loading

AndrewKahr commented Apr 22, 2023

webbertakken commented Apr 22, 2023 • edited Loading

AndrewKahr commented Apr 22, 2023

webbertakken commented Apr 22, 2023 • edited by GabLeRoux Loading

AndrewKahr commented Apr 22, 2023

webbertakken commented Apr 22, 2023

webbertakken commented Apr 22, 2023

AndrewKahr commented Apr 22, 2023 • edited Loading

webbertakken commented Apr 22, 2023

AndrewKahr commented Apr 22, 2023 • edited Loading

webbertakken left a comment

Choose a reason for hiding this comment

webbertakken Jun 4, 2024

Choose a reason for hiding this comment

webbertakken Jun 4, 2024

Choose a reason for hiding this comment

AndrewKahr Jun 5, 2024

Choose a reason for hiding this comment

webbertakken Jun 4, 2024

Choose a reason for hiding this comment

webbertakken Jun 4, 2024

Choose a reason for hiding this comment

AndrewKahr commented Apr 22, 2023 •

edited

Loading

webbertakken commented Apr 22, 2023 •

edited

Loading

webbertakken commented Apr 22, 2023 •

edited

Loading

webbertakken commented Apr 22, 2023 •

edited by GabLeRoux

Loading

AndrewKahr commented Apr 22, 2023 •

edited

Loading

AndrewKahr commented Apr 22, 2023 •

edited

Loading