Fix github auth app issues (#49)

game-ci · Jun 5, 2024 · df93ec5 · df93ec5
1 parent bd3002f
commit df93ec5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -81,6 +81,12 @@ jobs:
       - name: Deploy to Firebase
         uses: w9jds/firebase-action@v13.10.2
         with:
-          args: deploy --except functions:testFunction
+          args: deploy
+        env:
+          GCP_SA_KEY: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_UNITY_CI_VERSIONS }}'
+      - name: Cleanup Firebase Test
+        uses: w9jds/firebase-action@v13.10.2
+        with:
+          args: functions:delete testFunction --force
         env:
           GCP_SA_KEY: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_UNITY_CI_VERSIONS }}'
diff --git a/functions/src/config/settings.ts b/functions/src/config/settings.ts
@@ -20,8 +20,7 @@ export const settings = {
   },
   github: {
     auth: {
-      id: 84327,
-      installationId: 12321333,
+      appId: 84327,
       clientId: 'Iv1.fa93dce6a47c9357',
     },
   },

diff --git a/functions/src/service/github.ts b/functions/src/service/github.ts
@@ -4,7 +4,7 @@ import { settings } from '../config/settings';
 import { logger } from 'firebase-functions/v2';
 
 export class GitHub {
-  // https://octokit.github.io/rest.js/v18
+  // https://octokit.github.io/rest.js/v20
   static async init(privateKey: string, clientSecret: string): Promise<Octokit> {
     const appOctokit = new Octokit({
       authStrategy: createAppAuth,